Skip to content

ZOOKEEPER-5032: StatsTrack(byte[]) throws NullPointerException when quota node data is null #2364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
julianchandras wants to merge 3 commits into
base: master
Choose a base branch
from
+28 −1
Open

ZOOKEEPER-5032: StatsTrack(byte[]) throws NullPointerException when quota node data is null #2364

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
470c9f8
initial fix and test
julianchandras Mar 24, 2026
b303a2e
fix style issues
julianchandras Mar 24, 2026
2745840
update test
julianchandras Mar 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion zookeeper-server/src/main/java/org/apache/zookeeper/StatsTrack.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ public StatsTrack() {
* @param stat the byte[] stat to be initialized with
*/
public StatsTrack(byte[] stat) {
this(new String(stat, StandardCharsets.UTF_8));
this(stat == null ? null : new String(stat, StandardCharsets.UTF_8));
}

/**
Expand Down
27 changes: 27 additions & 0 deletions zookeeper-server/src/test/java/org/apache/zookeeper/test/StatsTrackTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,9 @@

package org.apache.zookeeper.test;

import org.apache.zookeeper.Quotas;
import org.apache.zookeeper.StatsTrack;
import org.apache.zookeeper.server.DataTree;
import org.junit.Assert;
import org.junit.Test;

Expand Down Expand Up @@ -132,4 +134,29 @@ public void testUpwardCompatibility() {
Assert.assertEquals(-1, st.getByteHardLimit());
Assert.assertEquals(-1, st.getCountHardLimit());
}

@org.junit.jupiter.api.Test
public void testCreateNodeWhenQuotaStatDataIsNull() throws Exception {
final DataTree tree = new DataTree();
final String path = "/bug";
final String childPath = path + "/child";
final String quotaPath = Quotas.quotaPath(path);
final String limitPath = Quotas.limitPath(path);
final String statPath = Quotas.statPath(path);

tree.createNode(path, new byte[0], null, -1, tree.getNode("/").stat.getCversion() + 1, 1, 1);
tree.createNode(quotaPath, null, null, -1, 1, 1, 1);

StatsTrack limit = new StatsTrack();
limit.setCountHardLimit(10);
tree.createNode(limitPath, limit.getStatsBytes(), null, -1, 1, 1, 1);

tree.createNode(statPath, new StatsTrack().getStatsBytes(), null, -1, 1, 1, 1);
tree.setData(statPath, null, -1, 2, 2);

tree.createNode(childPath, new byte[] { 1 }, null, -1, tree.getNode(path).stat.getCversion() + 1, 3, 3);

Assert.assertNotNull(tree.getNode(childPath));
Assert.assertNotNull(tree.getNode(statPath).getData());
}
}