Skip to content

ZOOKEEPER-5022: Added "exit" command to zkCli.sh #2358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
PDavid wants to merge 2 commits into
base: master
Choose a base branch
from
+23 −13
Open

ZOOKEEPER-5022: Added "exit" command to zkCli.sh #2358

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c7a42ef
ZOOKEEPER-5022: Added "exit" command to zkCli.sh
PDavid Mar 6, 2026
2824342
ZOOKEEPER-5022: Do not duplicate the quit section in zookeeperCLI.md
PDavid Mar 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions zookeeper-docs/src/main/resources/markdown/zookeeperCLI.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ ZooKeeper -server host:port cmd args
delete [-v version] path
deleteall path
delquota [-n|-b|-N|-B] path
exit
get [-s] [-w] path
getAcl [-s] path
getAllChildrenNumber path
Expand Down Expand Up @@ -345,8 +346,8 @@ A switch to turn on/off whether printing watches or not.
printwatches is on
```

## quit
Quit the CLI windows.
## quit (or exit)
The `quit` or `exit` command can be used to quit the CLI windows.

```bash
[zkshell: 1] quit
Expand Down
31 changes: 20 additions & 11 deletions zookeeper-server/src/main/java/org/apache/zookeeper/ZooKeeperMain.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,12 +77,21 @@ public boolean getPrintWatches() {
return printWatches;
}

private static final String CMD_CONNECT = "connect";
private static final String CMD_HISTORY = "history";
private static final String CMD_REDO = "redo";
private static final String CMD_QUIT = "quit";
private static final String CMD_EXIT = "exit";
private static final String CMD_PRINT_WATCHES = "printwatches";


static {
commandMap.put("connect", "host:port");
commandMap.put("history", "");
commandMap.put("redo", "cmdno");
commandMap.put("printwatches", "on|off");
commandMap.put("quit", "");
commandMap.put(CMD_CONNECT, "host:port");
commandMap.put(CMD_HISTORY, "");
commandMap.put(CMD_REDO, "cmdno");
commandMap.put(CMD_PRINT_WATCHES, "on|off");
commandMap.put(CMD_QUIT, "");
commandMap.put(CMD_EXIT, "");
Stream.of(CommandFactory.Command.values())
.map(command -> CommandFactory.getInstance(command))
// add all commands to commandMapCli and commandMap
Expand Down Expand Up @@ -409,34 +418,34 @@ protected boolean processZKCmd(MyCommandOptions co) throws CliException, IOExcep

LOG.debug("Processing {}", cmd);

if (cmd.equals("quit")) {
if (cmd.equals(CMD_QUIT) || cmd.equals(CMD_EXIT)) {
zk.close();
ServiceUtils.requestSystemExit(exitCode);
} else if (cmd.equals("redo") && args.length >= 2) {
} else if (cmd.equals(CMD_REDO) && args.length >= 2) {
Integer i = Integer.decode(args[1]);
if (commandCount <= i || i < 0) { // don't allow redoing this redo
throw new MalformedCommandException("Command index out of range");
}
cl.parseCommand(history.get(i));
if (cl.getCommand().equals("redo")) {
if (cl.getCommand().equals(CMD_REDO)) {
throw new MalformedCommandException("No redoing redos");
}
history.put(commandCount, history.get(i));
processCmd(cl);
} else if (cmd.equals("history")) {
} else if (cmd.equals(CMD_HISTORY)) {
for (int i = commandCount - 10; i <= commandCount; ++i) {
if (i < 0) {
continue;
}
System.out.println(i + " - " + history.get(i));
}
} else if (cmd.equals("printwatches")) {
} else if (cmd.equals(CMD_PRINT_WATCHES)) {
if (args.length == 1) {
System.out.println("printwatches is " + (printWatches ? "on" : "off"));
} else {
printWatches = args[1].equals("on");
}
} else if (cmd.equals("connect")) {
} else if (cmd.equals(CMD_CONNECT)) {
if (args.length >= 2) {
connectToZK(args[1]);
} else {
Expand Down
Loading