Skip to content

[ZEPPELIN-6725] Remove obsolete Py4J download properties from build g… - #5542

Merged
tbonelee merged 2 commits into
apache:masterfrom
gjenfwo:ZEPPELIN-6725
Oct 5, 2026
Merged

tbonelee merged 2 commits into
apache:masterfrom
gjenfwo:ZEPPELIN-6725

Conversation

@gjenfwo

@gjenfwo gjenfwo commented Oct 5, 2026 •

Copy link
Copy Markdown
Contributor

What is this PR for?

This PR fixes the build documentation for Py4J so it matches the actual Maven configuration in the repository. It removes obsolete properties and URL examples that are not used by the current build, and keeps the documented python.py4j.version entry aligned with the real Maven dependency version used in pom.xml. No build behavior, dependency version, or runtime artifact changes are included.

What type of PR is it?

Documentation

Todos

  • Update the build guide to remove unused Py4J download configuration entries

  • Clarify that python.py4j.version is the Maven dependency version

  • Align the documented default with pom.xml

  • Keep bundled Py4J source ZIP behavior clearly separated from the Maven dependency

What is the Jira issue?

How should this be tested?

  • Confirm that no repository references remain for pypi.repo.url or python.py4j.repo.folder
  • Compare the documented python.py4j.version default with pom.xml
  • Review the “Optional configurations” section to confirm it no longer describes non-existent Py4J download properties

Screenshots (if appropriate)

Questions:

Does the license files need to update? No
Is there breaking changes for older versions? No
Does this needs documentation? Yes, this PR updates the build documentation

@tbonelee tbonelee left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pom.xml and JIRA links in the description point to local vscode-file:// paths. Since the description becomes the merge commit message, could you fix them?

Comment thread docs/setup/basics/how_to_build.md Outdated
@gjenfwo

gjenfwo commented Oct 5, 2026

Copy link
Copy Markdown
Contributor Author

e pom.xml and JIRA links in the description point to local vscode-file:// paths. Since the description becomes the merge commit message, could you fix them?

I edited! 😀

voidmatcha
voidmatcha previously approved these changes Oct 5, 2026

@voidmatcha voidmatcha left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tbonelee
tbonelee merged commit a6b101e into apache:master Oct 5, 2026
24 of 25 checks passed
@tbonelee

tbonelee commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

Merged into master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants