Skip to content

[ZEPPELIN-6676] Match notebook status, result codes and dataset types to server values - #5538

Closed
miinhho wants to merge 1 commit into
apache:masterfrom
miinhho:ZEPPELIN-6676-upstream-finite-values
Closed

miinhho wants to merge 1 commit into
apache:masterfrom
miinhho:ZEPPELIN-6676-upstream-finite-values

Conversation

@miinhho

@miinhho miinhho commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

What is this PR for?

The SDK declares paragraph status and result codes as open strings and omits SVG and NULL dataset types. Match these declarations to the server?s seven job states, four result codes and eight dataset types.

Update the affected consumers in the same PR. Use the server?s terminal-state classification, render SVG as an encoded image, and clear previous output for NULL. Prevent pending output work from restoring content cleared by SVG or NULL. Keep explicit handling for every dataset type without changing existing unsupported-type behavior.

Server evidence:

  • zeppelin-interpreter/src/main/java/org/apache/zeppelin/scheduler/Job.java:56-80
  • zeppelin-interpreter/src/main/java/org/apache/zeppelin/interpreter/InterpreterResult.java:40-61

What type of PR is it?

Bug Fix

Todos

  • Correct finite types and adapt affected consumers.
  • Add type, rendering and output-transition regression tests.

What is the Jira issue?

https://issues.apache.org/jira/browse/ZEPPELIN-6676

Slice 1 of 3: finite value corrections. Structural/scalar corrections and Angular object removal compatibility will follow as separate PRs after this slice merges.

How should this be tested?

Run from the repository root after installing frontend dependencies:

cd zeppelin-web-angular
npm run typecheck:sdk-contracts
npm run test:shell
npm run check:websocket-contract
npx ngc -p src/tsconfig.json --noEmit

cd projects/zeppelin-react
npm test

Screenshots (if appropriate)

Not required.

Questions:

  • Does the license files need to update? No.
  • Is there breaking changes for older versions? TypeScript callers using arbitrary status/result strings must narrow them to the exported types. No server wire-format change.
  • Does this needs documentation? The type migration note is included above.

… to server values

Constrain paragraph snapshot and event states, result codes, and dataset types.
Adapt Angular and React consumers, including SVG/NULL output and pending work
invalidated by those output resets. Keep unrelated renderer behavior unchanged.

Server evidence (paths relative to the repository root):
- ParagraphItem.status, ParagraphStatus.status and terminal classification:
  zeppelin-interpreter/src/main/java/org/apache/zeppelin/scheduler/Job.java:56-80
  (enumerated all seven Status values and isCompleted).
- ParagraphResults.code and DatasetType:
  zeppelin-interpreter/src/main/java/org/apache/zeppelin/interpreter/InterpreterResult.java:40-61
  (enumerated all four Code and eight Type values).
@miinhho
miinhho force-pushed the ZEPPELIN-6676-upstream-finite-values branch from a05d0b0 to 5fcd6ab Compare October 5, 2026 10:55
@miinhho

miinhho commented Oct 5, 2026

Copy link
Copy Markdown
Contributor Author

This branch has another change from other pr. I will close this pr and reopen with the changes I intended

@miinhho miinhho closed this Oct 5, 2026
@miinhho
miinhho deleted the ZEPPELIN-6676-upstream-finite-values branch October 8, 2026 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant