Skip to content

[ZEPPELIN-6473] Replace deprecated substr() with slice() in note-create #5305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kimyenac wants to merge 1 commit into
base: master
Choose a base branch
from
+3 −3
Open

[ZEPPELIN-6473] Replace deprecated substr() with slice() in note-create #5305

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions zeppelin-web-angular/src/app/share/note-create/note-create.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ export class NoteCreateComponent extends MessageListenersManager implements OnIn
this.noteListService.notes.flatList.forEach(note => {
const noteName = note.path;
if (noteName.match(/^\/Untitled Note [0-9]*$/)) {
const lastCount = +noteName.substr(15);
const lastCount = +noteName.slice(15);
if (newCount <= lastCount) {
newCount = lastCount + 1;
}
Expand All @@ -63,13 +63,13 @@ export class NoteCreateComponent extends MessageListenersManager implements OnIn
let newCloneName = '';
const lastIndex = cloneNote.name.lastIndexOf(' ');
const endsWithNumber = !!cloneNote.name.match('^.+?\\s\\d$');
const noteNamePrefix = endsWithNumber ? cloneNote.name.substr(0, lastIndex) : cloneNote.name;
const noteNamePrefix = endsWithNumber ? cloneNote.name.slice(0, lastIndex) : cloneNote.name;
const regexp = new RegExp(`^${noteNamePrefix}.+`);

this.noteListService.notes.flatList.forEach(note => {
const noteName = note.path;
if (noteName.match(regexp)) {
const lastCopyCount = parseInt(noteName.substr(lastIndex).trim(), 10);
const lastCopyCount = parseInt(noteName.slice(lastIndex).trim(), 10);
newCloneName = noteNamePrefix;
if (copyCount <= lastCopyCount) {
copyCount = lastCopyCount + 1;
Expand Down
Loading