Skip to content

[ZEPPELIN-6475] Throw clear error for missing InfluxDB token #5301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ParkGyeongTae merged 2 commits into from
Jul 16, 2026
+45 −2
Merged

[ZEPPELIN-6475] Throw clear error for missing InfluxDB token #5301

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fec8d7b
[ZEPPELIN-6475] Throw clear error for missing InfluxDB token
gyowoo1113 Jul 14, 2026
5d4c7f5
[ZEPPELIN-6475] Replace trim().isEmpty() with isBlank()
gyowoo1113 Jul 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions influxdb/src/main/java/org/apache/zeppelin/influxdb/InfluxDBInterpreter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,12 +169,17 @@ private QueryApi getQueryApi() {


@Override
public void open() {
public void open() throws InterpreterException {

if (this.client == null) {
String token = getProperty(INFLUXDB_TOKEN_PROPERTY);
if (token == null || token.isBlank()) {
throw new InterpreterException("influxdb.token property is not set. Please configure the InfluxDB auth token.");
}

InfluxDBClientOptions opt = InfluxDBClientOptions.builder()
.url(getProperty(INFLUXDB_API_URL_PROPERTY))
.authenticateToken(getProperty(INFLUXDB_TOKEN_PROPERTY).toCharArray())
.authenticateToken(token.toCharArray())
.logLevel(LogLevel.valueOf(
getProperty(INFLUXDB_LOGLEVEL_PROPERTY, LogLevel.NONE.toString())))
.org(getProperty(INFLUXDB_ORG_PROPERTY))
Expand Down
38 changes: 38 additions & 0 deletions influxdb/src/test/java/org/apache/zeppelin/influxdb/InfluxDBInterpeterTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@
package org.apache.zeppelin.influxdb;

import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertThrows;
import static org.junit.jupiter.api.Assertions.assertTrue;
import static org.junit.jupiter.api.Assertions.fail;

import java.io.IOException;
Expand Down Expand Up @@ -216,6 +218,42 @@ public void after() throws IOException {
}
}

@Test
void testOpenWithoutToken() {
properties.remove("influxdb.token");

InfluxDBInterpreter interpreter = new InfluxDBInterpreter(properties);

InterpreterException exception = assertThrows(InterpreterException.class, interpreter::open);

assertTrue(exception.getMessage().contains("influxdb.token"));
assertTrue(exception.getMessage().contains("not set"));
}

@Test
void testOpenWithEmptyToken() {
properties.setProperty("influxdb.token","");

InfluxDBInterpreter interpreter = new InfluxDBInterpreter(properties);

InterpreterException exception = assertThrows(InterpreterException.class, interpreter::open);

assertTrue(exception.getMessage().contains("influxdb.token"));
assertTrue(exception.getMessage().contains("not set"));
}

@Test
void testOpenWithBlankToken() {
properties.setProperty("influxdb.token"," ");

InfluxDBInterpreter interpreter = new InfluxDBInterpreter(properties);

InterpreterException exception = assertThrows(InterpreterException.class, interpreter::open);

assertTrue(exception.getMessage().contains("influxdb.token"));
assertTrue(exception.getMessage().contains("not set"));
}

@Test
void testSigleTable() throws InterpreterException {

Expand Down
Loading