Skip to content

[ZEPPELIN-6419] Fix clone paragraph content loss caused by shortCircuit seq filtering #5254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kevinjmh wants to merge 3 commits into
base: master
Choose a base branch
from
+2 −23
Open

[ZEPPELIN-6419] Fix clone paragraph content loss caused by shortCircuit seq filtering #5254

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d59a035
[ZEPPELIN-6419] Fix clone paragraph content loss caused by overly agg…
kevinjmh May 21, 2026
77c59ab
fix CI
kevinjmh May 22, 2026
3e8d464
update
kevinjmh May 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions zeppelin-web-angular/projects/zeppelin-sdk/src/interfaces/message-paragraph.interface.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,10 +77,10 @@ export interface ParagraphConfig {
}

export interface ParagraphResults {
[index: number]: Record<string, unknown>;

code?: string;
msg?: ParagraphIResultsMsgItem[];

[index: number]: Record<string, unknown>;
}

export enum DatasetType {
Expand Down
21 changes: 0 additions & 21 deletions zeppelin-web-angular/projects/zeppelin-sdk/src/message.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,27 +174,6 @@ export class Message {
receive<K extends keyof MessageReceiveDataTypeMap>(op: K): Observable<Record<K, MessageReceiveDataTypeMap[K]>[K]> {
return this.received$.pipe(
filter(message => message.op === op),
filter(message => {
if (!message.msgId) {
// when msgId is not specified, it is not response to client request.
// always process them
return true;
}
const uniqueClientId = message.msgId.split('-')[0];
const msgIdSeqReceived = parseInt(message.msgId.split('-')[1], 10);
const isResponseForRequestFromThisClient = uniqueClientId === this.uniqueClientId;

if (message.op === OP.PARAGRAPH) {
if (isResponseForRequestFromThisClient && this.lastMsgIdSeqSent > msgIdSeqReceived) {
console.log('PARAPGRAPH is already updated by shortcircuit');
return false;
} else {
return true;
}
} else {
return true;
}
}),
map(message => message.data)
) as Observable<Record<K, MessageReceiveDataTypeMap[K]>[K]>;
}
Expand Down
Loading