BATIK-1271: thread-safe AWTGlyphGeometryCache using ConcurrentHashMap #67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xzel23
reviewed
Nov 17, 2025
batik-gvt/src/main/java/org/apache/batik/gvt/font/AWTGlyphGeometryCache.java
Show resolved
Hide resolved
xzel23
reviewed
Nov 17, 2025
batik-gvt/src/main/java/org/apache/batik/gvt/font/AWTGlyphGeometryCache.java
Outdated
Show resolved
Hide resolved
xzel23
reviewed
Nov 17, 2025
batik-gvt/src/main/java/org/apache/batik/gvt/font/AWTGlyphGeometryCache.java
Outdated
Show resolved
Hide resolved
xzel23
reviewed
Nov 17, 2025
xzel23
left a comment
xzel23
left a comment
There was a problem hiding this comment.
Hi @BuZZ-dEE , I am not a project member, so I can neither approve nor reject anything. But I have added some comments that you might want to look into. The new implementation looks much cleaner, I like it.
What would be nice to know:
- have you tried this implementation with your multi-threaded program? I think it should solve the cache issue.
- Do you see any performance degradation? I think it should be negligible, it might even perform better than before in some cases.
BuZZ-dEE
force-pushed
the
BATIK-1271_thread_safe_AWTGlyphGeometryCache
branch
from
efb024b to
f4ff620
Compare
…ntHashMap Co-authored-by: Michael Möller <[email protected]> Co-authored-by: Sebastian Schlatow <[email protected]>
BuZZ-dEE
force-pushed
the
BATIK-1271_thread_safe_AWTGlyphGeometryCache
branch
from
f4ff620 to
781ecc5
Compare
Author
@xzel23 We have adopted the proposed change
We're currently testing this.
Not yet. It looks goods so far. We will monitor this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/BATIK-1271