Skip to content

Conversation

SingingBush
Copy link

@SingingBush SingingBush commented Apr 7, 2025

As per https://issues.apache.org/jira/browse/BATIK-1380 there are some maven modules that don't actually need to have xml-apis-ext listed as a dependency

@stanio
Copy link

stanio commented Jun 29, 2025

A fair few of the Batik modules have a dependency on xml-apis that's not required.

It could be deemed subjective. mvn dependency:analyze shows a fair amount of:

[WARNING] Used undeclared dependencies found:
[WARNING]    xml-apis:xml-apis:jar:1.4.01:compile

So the corresponding modules have a direct dependency on xml-apis. However, they get it transitively via batik-dom (see mvn dependency:tree), and I would argue it is ok that xml-apis is not declared explicitly everywhere it is used directly, as if it is declared as an api Gradle dependency to batik-dom, or like require transitive JPMS dependency.

@SingingBush
Copy link
Author

I've updated the description in Jira as it was a little unclear. This pr is removing xml-apis-ext from the maven modules that don't use it.

@stanio
Copy link

stanio commented Jul 13, 2025

Ah, yes. I had been looking at the wrong dependency. My assessment with the xml-apis-ext is similar. mvn dependency:analyze reports it as "Used undeclared dependencies found" for 10 modules, however, it is transitively provided by batik-css, which API extends and exposes xml-apis-ext types. Thus, I don't think an explicit xml-apis-ext dependency is necessary where batik-css (or batik-dom) is already declared.

@SingingBush SingingBush changed the title BATIK-1380: Reduce xml-apis usage BATIK-1380: remove xml-apis-ext from dependencies of sub-projects that don't need it Jul 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants