escalate: POST body escalation fix #12655
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a test for POST body failover via the escalate plugin. This also fixes the tunnel logic so the body can be sent, especially for small POST bodies.
bneradt
force-pushed
the
fix_escalate_with_post_bodies
branch
from
7501d11 to
761d17b
Compare
moonchen
reviewed
Dec 1, 2025
| // but limit it to the actual content length to avoid copying pipelined requests. | ||
| if (p->vc_type == HttpTunnelType_t::HTTP_CLIENT && sm->enable_redirection && body_bytes_to_copy == 0) { | ||
| int64_t bytes_available = p->buffer_start->read_avail(); | ||
| bytes_to_copy_now = (p->total_bytes >= 0) ? std::min(bytes_available, p->total_bytes) : bytes_available; |
Contributor
There was a problem hiding this comment.
What would happen here if the POST request is chunked? I think p->total_bytes is INT64_MAX so it would copy everything buffered from TLS, including possibly the next pipelined POST request?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a test for POST body failover via the escalate plugin. This also fixes the tunnel logic so the body can be sent, especially for small POST bodies.