Fix DNS error logging to use ERR_DNS_FAIL #12638
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed a pointer comparison bug where the error_body_type string literal was compared by pointer address instead of value. This now passes the Dns_error_body constant directly so the pointer comparison succeeds and DNS errors are correctly logged as ERR_DNS_FAIL.
bneradt
added a commit
to bneradt/trafficserver
that referenced
this pull request
Nov 10, 2025
Fixed a pointer comparison bug where the error_body_type string literal was compared by pointer address instead of value. This now passes the Dns_error_body constant directly so the pointer comparison succeeds and DNS errors are correctly logged as ERR_DNS_FAIL.
Contributor
Author
|
For 10.1.x: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a pointer comparison bug where the error_body_type string literal was compared by pointer address instead of value. This now passes the Dns_error_body constant directly so the pointer comparison succeeds and DNS errors are correctly logged as ERR_DNS_FAIL.
For Review
trafficserver/src/proxy/http/HttpTransact.cc
Line 59 in 0d4f77c
trafficserver/src/proxy/http/HttpTransact.cc
Line 8058 in 0d4f77c
Note that in the comparison referenced above, it was a pointer comparison rather than a string comparison. Thus it would always fail since the two always pointed to two different string literals. This change makes the pointer comparison work as expected.