Repository navigation
TIKA-5057: deep dive rewrite of the Onenote parser - #3564
Merged
Merged
Conversation
Contributor
Author
|
After the second commit: Measured on
|
…neNote parser Nothing reachable from OneNoteParser uses the serialize path, the FSSHTTPD chunking/builder side, the node-object classes, or the unsigned/ helpers. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…tive OneNote parser
…section walk is empty
…soft breaks as newlines, drop placeholder-only paragraphs
…tted count; walk shared objects once per context; drop author NUL terminators
tballison
changed the title
…s marked-up body text
…-text labels; note why extended ASCII stays windows-1252
…sections... OneNote 2007 picture and ink objects as raw data; keep hyperlink paragraph text, linking the hyperlink runs Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
keep edited OneNote objects; inherit empty global ID tables; read multi-fragment transaction logs Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…not from MS-ONESTORE
…bjects per revision
…earlier revisions
…ip deleted FSSHTTPB version contexts quietly
…t; includePageHistory gives their older page versions Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
tballison
marked this pull request as ready for review
November 9, 2026 19:34
…hing them... which fixes encrypted-section detection; stop shared printout source files from inheriting a page image's name Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…dePageHistory is set walk the current revision's metadata roots instead of a second walk over every revision Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…isit budget and cache them
Contributor
|
I've ran out of budget 😮😂 |
…TTPB manifests once, extract each stored file once and cap embedded bytes at the file size
Contributor
Author
|
Oh, no. Sorry and thank you @THausherr ! |
…op using exceptions as control flow - review round 3
…nd build cleanups
Contributor
|
Had the 🤖 take a look, lmk what you think. Used carbon for the review (I assume claude will be lenient toward itself) but its english is a little harder to read imo. |
Contributor
Author
|
Thank you @henry-lindeman-glean . Bot is churning. Self-reviews this morning fixed just short of half of those already, but, y, there's a lot more to do. Go 🤖 , go! |
… cache; review fixes
- skip the no-content dump when the walk withheld history, deleted pages or
declined attachments (empty .onetoc2 walks still fall back)
- keep saved-version page GUIDs with includePageHistory
- validate chunk references; bound lazy property-set reads by their chunk;
read the FileDataStoreObject footer at its offset; reject negative positions
- 4-page aligned read cache (testOneNote2.one: 205x -> 4x file size read)
- drop the duplicate InlineInkWords constant, the BitReader GUID cache and the
unused MSOneStorePackage options parameter; comment fixes
- onetoc2 in supported formats; BREAKING CHANGES entry
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ons; review cleanups
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…eNote parser
And other OneNote improvements