Remove dependency on docker/login-action#3363
Open
zsy056 wants to merge 1 commit intoapache:masterfrom
Open
Conversation
mergeable
bot
added
the
github_actions
Member
|
Whats the purpose of this change? |
Contributor
Author
Hi Jens, it seems recently Apache org has enabled some policy that will block any unapproved GitHub Action like docker/login-action. This change removed that dependency so that this workflow can be run again. |
kpumuk
reviewed
Mar 27, 2026
.github/workflows/msvc.yml
Outdated
|
|
||
| permissions: | ||
| contents: read | ||
| packages: write |
Contributor
There was a problem hiding this comment.
Global write permission is considered a security risk. I would recommend to move it down to a specific job that needs write permissions.
See https://github.com/ossf/scorecard/blob/main/docs/checks.md#token-permissions
Contributor
Author
There was a problem hiding this comment.
Thanks, moved write permission to the job
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[skip ci]anywhere in the commit message to free up build resources.