Conversation
|
I would like for the
I believe so but I don't know for sure. I saw that the Thrift Maven plugin was available within the Thrift project's source code so I created a patch to build it in a way similar to other Java parts of Thrift. If the Maven plugin in Thrift's source code is not compliant with the Apache Foundation's release policy, then I'd like to know what I could change to make it acceptable, as the Maven plugin provides a lot of value. |
|
I just wonder because we usually publish the Java packages via maven. Als I'm being told the maven plugin did not change for a long time. Disclaimer: I'm no Java user myself, so pls bear with me if I misrepresent sth and/or my knowledge is outdated. I might add that the Java publishing is always kind of a hassle, so if we can make it better, I'm open to it. @jeking3 thoughts? |
All of the AppVeyor builds fail? |
|
As an alternative, I would propose deleting the thrift-maven-plugin, or moving it to its own separate repository, instead of shipping it in the contrib directory. Its functions are trivially replaced by exec-maven-plugin and build-helper-maven-plugin, so its existence doesn't really offer much value and its build probably should not complicate the main thrift build at all. |
This change builds the
thrift-maven-pluginin thecontribfolder with Maven by default.The intention is to keep
org.apache.thrift:thrift-maven-pluginupdated as Thrift evolves.