fix: prevent orphaned sessions when lakeFS abort fails#4197
Open
xuang7 wants to merge 7 commits intoapache:mainfrom
Open
fix: prevent orphaned sessions when lakeFS abort fails#4197xuang7 wants to merge 7 commits intoapache:mainfrom
xuang7 wants to merge 7 commits intoapache:mainfrom
Conversation
Contributor
|
@aicam can you review this pr? |
Contributor
|
@aicam Can you review this PR? |
Contributor
|
@xuang7 can you add 1 test to simulate failure and then ensure abort is ok? Thanks |
…o fix/multipart-abort-cleanup
Contributor
Contributor
|
LGTM |
Contributor
|
@aicam Please merge it if you think it's ready. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
This PR fixes the issue where a failed LakeFS abort call could cause the database transaction to roll back, leaving the upload session stuck in the database. It moves the LakeFS abort call outside the database transaction in abortMultipartUpload to prevent orphaned upload sessions. The transaction now handles validation and DB cleanup, returning the necessary values (repoName, uploadId, physicalAddress) as a tuple. After the transaction commits, the LakeFS abort is called separately, so the session is always cleaned up regardless of whether LakeFS succeeds.
Any related issues, documentation, discussions?
Fixes #4196
How was this PR tested?
Manually tested
Was this PR authored or co-authored using generative AI tooling?
No