Open
Conversation
aicam
requested changes
Feb 2, 2026
Contributor
aicam
left a comment
There was a problem hiding this comment.
I see old affiliation modal is removed, please make sure to delete all old code
amber/src/main/scala/org/apache/texera/web/auth/UserAuthenticator.scala
Outdated
Show resolved
Hide resolved
amber/src/main/scala/org/apache/texera/web/resource/dashboard/user/UserResource.scala
Show resolved
Hide resolved
...app/common/service/user/registration-request-modal/registration-request-modal.component.html
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
Summary
To gather more user information for a better overview of users, this PR introduces a new column 'joining_reason' to the user table. Now when a user logins to the Texera for the first time, they will be prompted to enter their affiliation(optional) and reason of joining Texera. The answer will be recorded to the database and retrieved when admins enter the admin dashboard. The prior affiliation modal implemented in #4113 has been removed. In accordance to the change, new APIs and files have been introduced to the system.
For Developers
Please do the following steps to incorporate with new changes:
Screenshots of the modal
Sample Video
Screen.Recording.2026-01-30.at.19.21.26.mp4
Design of the Feature
When a user logins to Texera for the first time, they will be prompted to enter their affiliation (optional) and reason of joining Texera (required) to send request to admin users. Once they finish filling out the form, until they get approved (role gets changed from INACTIVE to REGULAR), they will keep seeing a message informing them to wait until an admin user grants them access.
The new
joining_reasoncolumn inusertable will be used to determine if the system needs to prompt the user or not.joining_reasonis null, then the modal will prompt user to enter affiliation and joining reason (first time logging in).joining_reasonis not null, then the user has answered the form before. The system will not prompt, but will inform user to wait until an admin user grants access to the user.Current version of Texera has two forms related to user registration:
As we see redundance on these modals, we decided to combine these modals into one modal, therefore we are removing the two modals mentioned above.
Current
userschemaProposed
userschemaBackend Changes
Added two new API calls:
Frontend Changes
registration-request-modalcomponent for the registration form.Any related issues, documentation, discussions?
Closes #4188.
How was this PR tested?
Manually tested.
Was this PR authored or co-authored using generative AI tooling?
Generated-by: ChatGPT 5.2