-
Notifications
You must be signed in to change notification settings - Fork 16.3k
feat: Dynamic currency #36416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
richardfogaca
wants to merge
37
commits into
apache:master
Choose a base branch
from
richardfogaca:feat-dynamic-currency
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: Dynamic currency #36416
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…AUTO currency mode
… cell-level detection (table, pivot_table_v2)
…legacy and modern API consistency
Contributor
Contributor
Contributor
|
🎪 Showtime deployed environment on GHA for 5b992bb • Environment: http://35.162.7.251:8080 (admin/admin) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api
Related to the REST API
change:backend
Requires changing the backend
change:frontend
Requires changing the frontend
packages
plugins
risk:db-migration
PRs that require a DB migration
size/XXL
size:XXL
This PR changes 1000+ lines, ignoring generated files
🎪 5b992bb 🤡 eschutho
Environment 5b992bb requested by eschutho
🎪 5b992bb 🚦 running
Environment 5b992bb status: running
🎪 5b992bb 🌐 35.162.7.251:8080
Environment 5b992bb URL: http://35.162.7.251:8080 (click to visit)
🎪 5b992bb ⌛ 48h
Environment 5b992bb expires after 48h
🎪 5b992bb 📅 2025-12-09T01-28
Environment 5b992bb created at 2025-12-09T01-28
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Adds dynamic currency detection for chart formatting. When a metric's currency is set to "Auto-detect", Superset queries the dataset's designated currency code column to determine the appropriate currency symbol.
How it works:
currency_code_column(e.g., a column containing "USD", "EUR", "GBP")Key changes:
Backend:
currency_code_columnfield to SqlaTable model with DB migrationdetect_currency()utility that queries distinct currencies from filtered datadetected_currencyin API response for frontend consumptionFrontend:
main_dttm_colfrom inline radio buttons to a new "Default Column Settings" section alongsidecurrency_code_columnExample data:
international_salesexample dataset demonstrating multi-currency transactions across regionsBEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A - Requires screenshot of:
TESTING INSTRUCTIONS
international_salesdataset and set "Currency code column" tocurrency_coderevenue)country = USA)ADDITIONAL INFORMATION
CodeAnt-AI Description
Auto-detect currency from dataset and per-row for chart formatting
What Changed
Impact
✅ Clearer currency symbols in charts when dataset provides a currency column✅ Fewer mixed-currency formatting errors (mixed rows now show neutral numbers)✅ Auto-detect option only appears when it will work for the selected dataset💡 Usage Guide
Checking Your Pull Request
Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.
Talking to CodeAnt AI
Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:
This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.
Example
Preserve Org Learnings with CodeAnt
You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:
This helps CodeAnt AI learn and adapt to your team's coding style and standards.
Example
Retrigger review
Ask CodeAnt AI to review the PR again, by typing:
Check Your Repository Health
To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.