fix: Columns bleeding into other cells #36134
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Based on your review schedule, I'll hold off on reviewing this PR until it's marked as ready for review. If you'd like me to take a look now, comment
|
geido
added
the
🎪 ⚡ showtime-trigger-start
github-actions
bot
added
🎪 4debf25 🚦 building
Contributor
github-actions
bot
added
🎪 4debf25 🚦 deploying
Contributor
|
🎪 Showtime deployed environment on GHA for 4debf25 • Environment: http://44.247.232.225:8080 (admin/admin) |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a visual issue where table content was bleeding through sticky header and total rows in the Pivot Table component. The fix ensures that frozen/sticky elements properly hide underlying content during scrolling.
Key Changes:
- Set
border-spacing: 0to eliminate gaps between cells that allowed content to show through - Applied theme background colors to sticky total row elements to ensure complete coverage of underlying content
- Added
z-index: 1to total row cells for proper layering
msyavuz
reviewed
Nov 21, 2025
superset-frontend/plugins/plugin-chart-pivot-table/src/react-pivottable/Styles.js
Outdated
Show resolved
Hide resolved
github-actions
bot
removed
🎪 4debf25 🚦 running
geido
reviewed
Nov 24, 2025
superset-frontend/plugins/plugin-chart-pivot-table/src/react-pivottable/Styles.js
Outdated
Show resolved
Hide resolved
Co-authored-by: Geidō <[email protected]>
geido
approved these changes
Nov 25, 2025
sadpandajoe
added
the
v6.0
sadpandajoe
pushed a commit
that referenced
this pull request
Nov 25, 2025
Co-authored-by: Diego Pucci <[email protected]> Co-authored-by: Geidō <[email protected]> (cherry picked from commit 062e4a2)
LuisSanchez
pushed a commit
to LuisSanchez/superset
that referenced
this pull request
Nov 25, 2025
Co-authored-by: Diego Pucci <[email protected]> Co-authored-by: Geidō <[email protected]>
aminghadersohi
pushed a commit
to aminghadersohi/superset
that referenced
this pull request
Nov 25, 2025
Co-authored-by: Diego Pucci <[email protected]> Co-authored-by: Geidō <[email protected]>
kshi020302
pushed a commit
to jl141/superset
that referenced
this pull request
Nov 30, 2025
Co-authored-by: Diego Pucci <[email protected]> Co-authored-by: Geidō <[email protected]>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Adjusted the Pivot Table styling so the sticky header/total areas no longer show underlying rows by zeroing out border-spacing, keeping the header row sticky, and relying on the theme background to cover the frozen cells. Restored sticky positioning on the header row while keeping it fully opaque with themed background colors.Applied the same background treatment to the sticky totals row so columns beneath it remain hidden during scroll.
BEFORE
AFTER
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION