[MINOR][GRAPHX] Remove unused arpack_combined_all dependency - #58891
Open
david-mollitor-db wants to merge 1 commit into
Open
david-mollitor-db wants to merge 1 commit into
david-mollitor-db wants to merge 1 commit into
Conversation
david-mollitor-db
force-pushed
the
graphx-drop-arpack
branch
from
September 18, 2026 20:37
0d644c2 to
05b7d3a
Compare
GraphX declares `net.sourceforge.f2j:arpack_combined_all` but never references it. Its only netlib user, `SVDPlusPlus`, uses BLAS (`dev.ludovic.netlib:blas`, retained) exclusively, and GraphX has no eigenvalue-decomposition code. ARPACK is used only by MLlib, which binds the modern `dev.ludovic.netlib:arpack` instead. `arpack_combined_all` (0.1) is a leftover from the old `com.github.fommil.netlib` era. GraphX is the sole declarer of this artifact repo-wide, so removing it drops the jar from the classpath; the dependency manifest is updated accordingly. Co-authored-by: Isaac <no-reply@databricks.com>
david-mollitor-db
force-pushed
the
graphx-drop-arpack
branch
from
September 18, 2026 20:39
05b7d3a to
d6f5ba6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR removes the redundant direct declaration of
net.sourceforge.f2j:arpack_combined_all(0.1) fromgraphx/pom.xml. That isthe only change -- the dependency manifest
(
dev/deps/spark-deps-hadoop-3-hive-2.3) is intentionally left unchanged (seebelow).
Why are the changes needed?
GraphX declares
arpack_combined_alldirectly but does not use ARPACK:SVDPlusPlus, uses BLAS exclusively (org.apache.spark.ml.linalg.BLAS,backed by
dev.ludovic.netlib:blas, which is retained). The only mentions of"arpack" in GraphX are comments in
PageRankSuitereferencing R'spage_rank(..., algo = "arpack"), unrelated to this Java library.ARPACK,EigenValueDecomposition,RowMatrix), which binds the moderndev.ludovic.netlib:arpack-- not theold F2J artifact.
The direct declaration is a leftover from the old
com.github.fommil.netlibera, before the migration to
dev.ludovic.netlib, and it is redundant:net.sourceforge.f2j:arpack_combined_all:0.1is a compile-scope transitivedependency of
dev.ludovic.netlib:arpack:3.2.0(the F2J referenceimplementation behind the modern ARPACK), which MLlib declares
(
mllib/pom.xml, version-managed in the rootpom.xml). The artifact thereforeremains on the build's resolved classpath through MLlib regardless of GraphX's
declaration.
Because removing GraphX's explicit edge does not change what the build resolves,
this is a build-file cleanup only, and the dependency manifest is left as-is.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Relies on existing CI.
dev/test-dependencies.shvalidates that the committedmanifest matches the classpath Maven actually resolves; because
arpack_combined_all-0.1.jaris still pulled in transitively viadev.ludovic.netlib:arpack, the resolved classpath is unchanged, the manifestneeds no update, and the check passes. This is a build-only change with no
runtime or test-behavior impact.
Was this patch authored or co-authored using generative AI tooling?
Generated-by: Isaac
This pull request and its description were written by Isaac.