[SPARK-56035] [SQL] Introduce AggregateValidator for single-pass resolver Aggregate validation#54866
Open
mihailoale-db wants to merge 1 commit intoapache:masterfrom
Open
[SPARK-56035] [SQL] Introduce AggregateValidator for single-pass resolver Aggregate validation#54866mihailoale-db wants to merge 1 commit intoapache:masterfrom
AggregateValidator for single-pass resolver Aggregate validation#54866mihailoale-db wants to merge 1 commit intoapache:masterfrom
Conversation
mihailoale-db
force-pushed
the
resolveraggvalidation
branch
from
38d3744 to
0eebaa2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Right now
fails with
MISSING_AGGREGATIONin the single-pass resolver because we can't match grouping and aggregate expressions sincesemanticEqualsrequires both expressions to be deterministic but we do the validation beforePulloutNonDeterministiccall.Why are the changes needed?
In order to fix the failing query.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Added + existing tests.
Was this patch authored or co-authored using generative AI tooling?
Yes.