Skip to content

Conversation

@dongjoon-hyun
Copy link
Member

@dongjoon-hyun dongjoon-hyun commented Oct 23, 2025

What changes were proposed in this pull request?

This PR aims to use Java 9+ Set.of() API instead of Collections.emptySet() and add Scalastyle and Checkstyle rules.

Why are the changes needed?

Like TableCatalog.java example of this PR, we had better use Set simply and uniformly from Apache Spark 4.1.0.

- import java.util.Collections;
...
- default Set<TableCatalogCapability> capabilities() { return Collections.emptySet(); }
+ default Set<TableCatalogCapability> capabilities() { return Set.of(); }

Does this PR introduce any user-facing change?

No behavior change.

How was this patch tested?

Pass the CIs.

Was this patch authored or co-authored using generative AI tooling?

No.

@vrozov
Copy link
Member

vrozov commented Oct 23, 2025

+1, LGTM.

@dongjoon-hyun
Copy link
Member Author

Thank you, @vrozov .

@dongjoon-hyun
Copy link
Member Author

Thank you, @HyukjinKwon . Merged to master for Apache Spark 4.1.0-preview3.

@dongjoon-hyun dongjoon-hyun deleted the SPARK-54007 branch October 24, 2025 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants