[SPARK-52578][SQL] Add numSourceRows metric for MergeIntoExec
#52669
+346
−227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asl3
changed the title
numSourceRows metric for MergeIntoExec
szehon-ho
reviewed
Oct 22, 2025
...e/src/main/scala/org/apache/spark/sql/execution/datasources/v2/WriteToDataSourceV2Exec.scala
Outdated
Show resolved
Hide resolved
...e/src/main/scala/org/apache/spark/sql/execution/datasources/v2/WriteToDataSourceV2Exec.scala
Outdated
Show resolved
Hide resolved
...e/src/main/scala/org/apache/spark/sql/execution/datasources/v2/WriteToDataSourceV2Exec.scala
Outdated
Show resolved
Hide resolved
szehon-ho
reviewed
Oct 22, 2025
| None | ||
| } | ||
|
|
||
| sourceChild.flatMap { child => |
There was a problem hiding this comment.
actually, why do we need to traverse again here? I thought join.left and join.right is already the child and we can directly check that node? We dont want to traverse as each node without numOutputRows risks a wrong information (because that node may change the numOutputRows from its child)
There was a problem hiding this comment.
I renamed to findSourceSide, as we still need a step to find the source node with numOutputRows.
For example, with:
+- *(2) BroadcastHashJoin ...
:- *(2) Project ...
: +- BatchScan ...
+- BroadcastQueryStage ...
+- BroadcastExchange ...
+- *(1) Project ...
+- *(1) LocalTableScan ...
we find BroadcastQueryStage has the source table (after checking isTargetTableScan), but still need a step to traverse for LocalTableScan. As it is collectFirst, I think we don't worry about traversing too far
szehon-ho
reviewed
Oct 23, 2025
sql/core/src/test/scala/org/apache/spark/sql/connector/MergeIntoTableSuiteBase.scala
Show resolved
Hide resolved
sql/core/src/test/scala/org/apache/spark/sql/connector/MergeIntoTableSuiteBase.scala
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add
numSourceRowsmetric forMergeIntoExec, from source node'snumOutputRows.Assumption is that all child nodes have
numOutputRows. If not found,numSourceRowswould be -1.Why are the changes needed?
Improve completeness and debuggability of Merge Into metrics.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Unit test cases for numSourceNodes metric.
Was this patch authored or co-authored using generative AI tooling?
No.