-
Notifications
You must be signed in to change notification settings - Fork 28.9k
[SPARK-53744][PYTHON][TESTS] Update black python to 24.3.0
#51687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
The large number of changes was required to get the CI tests to pass with the new version |
|
Would you be able to add more details in the PR why the large number of formatting changes were needed to pass the CI tests? If this dependency upgrade changes the behavior of CI tests, it would be good to explain that in the description |
It is due to the style changes within black between version 23.12.1 and 24.3.0. |
|
Thanks for linking the changes.md for reference. I'm comparing with the previous PR that upgraded the black version to 23.12.1 and I see a couple of files which might also need to have the black version be updated:
|
python/pyspark/sql/tests/connect/test_parity_python_datasource.py
Outdated
Show resolved
Hide resolved
Thanks I must have missed those in my search |
f611f17 to
8ee89c8
Compare
jcw024
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes LGTM!
8ee89c8 to
4734636
Compare
4734636 to
2a9f5bb
Compare
black python to 24.3.0
074de92 to
4b6ef93
Compare
black python to 24.3.0black python to 24.3.0
|
To @eschcam , please get a new JIRA ID because we are already in the difficult situation because of reusing of SPARK-52844. |
black python to 24.3.0black python to 24.3.0
Apologies. I was unaware a Jira ticket couldn't be used for multiple pull requests. I will keep this in mind for future PRs |
4b6ef93 to
6739fe3
Compare
ca57f2f to
39d40b2
Compare
39d40b2 to
c986431
Compare
3e6d3d2 to
43ae62d
Compare
These are required to endure compatibility with black https://black.readthedocs.io/en/stable/guides/using_black_with_other_tools.html#flake8
This reverts commit f4ab17ad599e28be0c9d1d0106dde2218c566b4d.
43ae62d to
f112190
Compare
What changes were proposed in this pull request?
Updating python dependency black from 23.12.1 to 24.3.0
Why are the changes needed?
To bring the latest improvements and bug fixes.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Passed all CI tests
Was this patch authored or co-authored using generative AI tooling?
No