Skip to content

Conversation

@eschcam
Copy link
Contributor

@eschcam eschcam commented Jul 28, 2025

What changes were proposed in this pull request?

Updating python dependency black from 23.12.1 to 24.3.0

Why are the changes needed?

To bring the latest improvements and bug fixes.

Does this PR introduce any user-facing change?

No

How was this patch tested?

Passed all CI tests

Was this patch authored or co-authored using generative AI tooling?

No

@eschcam
Copy link
Contributor Author

eschcam commented Jul 28, 2025

The large number of changes was required to get the CI tests to pass with the new version

@jcw024
Copy link

jcw024 commented Jul 29, 2025

Would you be able to add more details in the PR why the large number of formatting changes were needed to pass the CI tests? If this dependency upgrade changes the behavior of CI tests, it would be good to explain that in the description

@eschcam
Copy link
Contributor Author

eschcam commented Jul 29, 2025

Would you be able to add more details in the PR why the large number of formatting changes were needed to pass the CI tests? If this dependency upgrade changes the behavior of CI tests, it would be good to explain that in the description

It is due to the style changes within black between version 23.12.1 and 24.3.0.
I am not sure if there is a good way of summarising CHANGES.md as there are a number of style changes

@jcw024
Copy link

jcw024 commented Jul 29, 2025

Thanks for linking the changes.md for reference.

I'm comparing with the previous PR that upgraded the black version to 23.12.1 and I see a couple of files which might also need to have the black version be updated:

  • .github/workflows/pages.yml
  • dev/spark-test-image/docs/Dockerfile

@eschcam
Copy link
Contributor Author

eschcam commented Jul 30, 2025

Thanks for linking the changes.md for reference.

I'm comparing with the previous PR that upgraded the black version to 23.12.1 and I see a couple of files which might also need to have the black version be updated:

* .github/workflows/pages.yml

* dev/spark-test-image/docs/Dockerfile

Thanks I must have missed those in my search

@eschcam eschcam marked this pull request as draft July 30, 2025 16:02
@eschcam eschcam marked this pull request as ready for review July 30, 2025 16:19
@eschcam eschcam requested review from HyukjinKwon and jcw024 August 1, 2025 10:38
Copy link

@jcw024 jcw024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes LGTM!

@eschcam eschcam changed the title [SPARK-52844][PYTHON][TESTS] Update black to 24.3.0 [SPARK-52844][PYTHON][TESTS] Update black python to 24.3.0 Sep 24, 2025
@dongjoon-hyun dongjoon-hyun changed the title [SPARK-52844][PYTHON][TESTS] Update black python to 24.3.0 [SPARK-XXX][PYTHON][TESTS] Update black python to 24.3.0 Sep 24, 2025
@dongjoon-hyun dongjoon-hyun marked this pull request as draft September 24, 2025 16:43
@dongjoon-hyun
Copy link
Member

To @eschcam , please get a new JIRA ID because we are already in the difficult situation because of reusing of SPARK-52844.

$ git log --oneline | grep SPARK-52844
ed326b2d13c [SPARK-52844][PYTHON] Update `protobuf` Python package to 5.29.5
43f650eaa43 [SPARK-52844][PYTHON] Update numpy to 1.22

@eschcam eschcam changed the title [SPARK-XXX][PYTHON][TESTS] Update black python to 24.3.0 [SPARK-53744][PYTHON][TESTS] Update black python to 24.3.0 Sep 29, 2025
@eschcam
Copy link
Contributor Author

eschcam commented Sep 29, 2025

To @eschcam , please get a new JIRA ID because we are already in the difficult situation because of reusing of SPARK-52844.

$ git log --oneline | grep SPARK-52844
ed326b2d13c [SPARK-52844][PYTHON] Update `protobuf` Python package to 5.29.5
43f650eaa43 [SPARK-52844][PYTHON] Update numpy to 1.22

Apologies. I was unaware a Jira ticket couldn't be used for multiple pull requests. I will keep this in mind for future PRs

@eschcam eschcam marked this pull request as ready for review September 29, 2025 12:53
@eschcam eschcam force-pushed the py-black-update branch 3 times, most recently from 3e6d3d2 to 43ae62d Compare November 10, 2025 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants