[SS][SPARK-52637] Fix version ID mismatch issue for RocksDB compaction leading to incorrect file mapping #51520
+79
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anishshri-db
approved these changes
Jul 16, 2025
|
@liviazhu - can you check if the failure is related ? |
@anishshri-db I ran it locally and it passed. Retriggered the run. |
haoyangeng-db
pushed a commit
to haoyangeng-db/apache-spark
that referenced
this pull request
Jul 22, 2025
…n leading to incorrect file mapping ### What changes were proposed in this pull request? We found a bug leading to checkpoint corruption with RocksDB VersionID Mismatch error due to local file mappings not being cleared correctly when native RocksDB does a compaction resulting in the original SST file not being deleted. This resulted in the DFS file UUID being reused for 2 SST files that were not the same, leading the version ID mismatch. This change purges from the local file mappings any mapping that was created by a version equal or greater than the one loaded. ### Why are the changes needed? The described bug fails streaming queries. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? New unit test ### Was this patch authored or co-authored using generative AI tooling? No Closes apache#51520 from liviazhu/liviazhu-db/versionid-mismatch. Authored-by: Livia Zhu <[email protected]> Signed-off-by: Anish Shrigondekar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
We found a bug leading to checkpoint corruption with RocksDB VersionID Mismatch error due to local file mappings not being cleared correctly when native RocksDB does a compaction resulting in the original SST file not being deleted. This resulted in the DFS file UUID being reused for 2 SST files that were not the same, leading the version ID mismatch.
This change purges from the local file mappings any mapping that was created by a version equal or greater than the one loaded.
Why are the changes needed?
The described bug fails streaming queries.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
New unit test
Was this patch authored or co-authored using generative AI tooling?
No