[SPARK-52817][SQL] Fix Like Expression performance
#51510
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you add a test to cover this change? |
|
Hi @wangyum Have Add UTs. |
|
Could you add description ? |
|
Can you provide more context in the PR description? I don't understand what you are doing in this PR. |
|
Have added. |
cloud-fan
reviewed
Jul 17, 2025
| private val endsWith = "%([^_%]+)".r | ||
| private val startsAndEndsWith = "([^_%]+)%([^_%]+)".r | ||
| private val contains = "%([^_%]+)%".r | ||
| private val startsWith = "([^_%]+)%+".r |
There was a problem hiding this comment.
So a single % is the same as more than one %? Can we leave a code comment to explain this case?
There was a problem hiding this comment.
According to automata theory, consecutive wildcard characters are equivalent to a single wildcard character.
Have added the code comment.
cloud-fan
approved these changes
Jul 18, 2025
dongjoon-hyun
changed the title
Like Expression performance
dongjoon-hyun
approved these changes
Jul 18, 2025
peter-toth
approved these changes
Jul 18, 2025
wangyum
approved these changes
Jul 18, 2025
|
Merged to master. |
haoyangeng-db
pushed a commit
to haoyangeng-db/apache-spark
that referenced
this pull request
Jul 22, 2025
### What changes were proposed in this pull request? Make contains function to be used in like expression with multiple '%'. ### Why are the changes needed? In some customers' cases , user sometimes use multiple '%' for like expression. For Example: ``` SELECT * FROM testData where value not like '%%HotFocus%%' SELECT * FROM testData where value not like '%%%HotFocus%%%' ``` In these SQL queries, cannot convert Like expressions to contains function in logical planning. So the performance is very poor. ### How was this patch tested? Added UTs and Existed UTs Closes apache#51510 from zhixingheyi-tian/fix-like. Authored-by: zhixingheyi-tian <[email protected]> Signed-off-by: Yuming Wang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Make contains function to be used in like expression with multiple '%'.
Why are the changes needed?
In some customers' cases , user sometimes use multiple '%' for like expression.
For Example:
In these SQL queries, cannot convert Like expressions to contains function in logical planning. So the performance is very poor.
How was this patch tested?
Added UTs and Existed UTs