[DRAFT] Resolve default string producing expressions in analyzer #49607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefankandic
force-pushed
the
resolveDefaultProducingStringFns
branch
from
150ae4a to
ec0ad23
Compare
stefankandic
commented
Jan 23, 2025
| } | ||
|
|
||
| private def needsCast(expression: Expression): Boolean = expression match { | ||
| case ex: DefaultStringProducingExpression => ex.getTagValue(CAST_ADDED_TAG).isEmpty |
There was a problem hiding this comment.
@cloud-fan Is there an easier way to do this that won't result in the infinite loop of always adding a cast on top of DefaultStringProducingExpression?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Changing
DefaultStringProducingExpressionexpressions to return the proper default collation (of either the session or the object for DDL commands)Why are the changes needed?
Previously,
DefaultStringProducingExpressionwould always return the collation of the session, however for DDL commands they should return the collation of the object.Does this PR introduce any user-facing change?
No.
How was this patch tested?
New unit tests.
Was this patch authored or co-authored using generative AI tooling?
No.