SOLR-18332: Replace CloudSolrStream 'qt' usage - #4816
Merged
gerlowskija merged 7 commits intoAug 28, 2026
Conversation
github-actions
Bot
added
documentation
gerlowskija
changed the title
gerlowskija
marked this pull request as ready for review
August 26, 2026 10:49
Contributor
|
Thanks for updating ref guide |
epugh
reviewed
Aug 26, 2026
Contributor
There was a problem hiding this comment.
I think I fixed this in main already, it came in three days ago when I added new tests...
dsmiley
approved these changes
Aug 26, 2026
| SolrResponse rsp; | ||
| try { | ||
| rsp = new QueryRequest(q).process(ccc.getSolrCloudManager().getSolrClient()); | ||
| rsp = new QueryRequest("/stream", q).process(ccc.getSolrCloudManager().getSolrClient()); |
Contributor
There was a problem hiding this comment.
not a QueryRequest appropriate request/usage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SOLR-18332
Description
The 'qt' parameter and several related methods in SolrJ are deprecated.
This deprecation may not stick, but it's still worth minimizing use of this
feature as much as possible.
One place where 'qt' is still used frequently is in CloudSolrStream (and
related "expression" strings.
Solution
This PR addresses this similarly to the recent #4747 : by giving
CloudSolrStream and friends a constructor parameter that allows users
to specify the path at creation-time instead of relying on "qt".
CloudSolrStream is also an "Expressible", meaning that it maps to our
user-facing streaming-expression syntax. So this PR also adds
"path" as a parameter name in that syntax.
(I used Claude to help me investigate and write some of this PR; especially
the test updates.)
Tests
Various streaming tests have been updated to use the new "path"
streaming expression parameter name. A test-case has been added with
the explicit purpose of testing the non-preferred "qt" syntax that was
supported prior to this PR. Existing tests continue to pass.
Checklist
Please review the following and check all that apply:
mainbranch../gradlew check.