Skip to content

build/tests: new tests.ssl option to force SSL when supported#4454

Merged
dsmiley merged 1 commit into
apache:mainfrom
dsmiley:SOLR-tests-ssl-option
Jun 3, 2026
Merged

build/tests: new tests.ssl option to force SSL when supported#4454
dsmiley merged 1 commit into
apache:mainfrom
dsmiley:SOLR-tests-ssl-option

Conversation

@dsmiley
Copy link
Copy Markdown
Contributor

@dsmiley dsmiley commented May 20, 2026

No description provided.

@dsmiley
Copy link
Copy Markdown
Contributor Author

dsmiley commented May 24, 2026

@epugh I recall about ~2 months ago, you wrote a test but it didn't work with SSL. Did I share a tip/trick to run tests with SSL that merely involved a setting at the CLI? I forget. If there is no such way to do it, then this PR would be useful.

One thing this PR doesn't do but maybe should is explicitly run with SSL randomization disabled. It only does the inverse right now.

@epugh
Copy link
Copy Markdown
Contributor

epugh commented May 25, 2026

@epugh I recall about ~2 months ago, you wrote a test but it didn't work with SSL. Did I share a tip/trick to run tests with SSL that merely involved a setting at the CLI? I forget. If there is no such way to do it, then this PR would be useful.

One thing this PR doesn't do but maybe should is explicitly run with SSL randomization disabled. It only does the inverse right now.

I am trying to remember which one it was, but yeah.. I know we have a lot of SuppressSSL littered about...

@dsmiley dsmiley merged commit ab4564b into apache:main Jun 3, 2026
3 of 5 checks passed
@dsmiley dsmiley deleted the SOLR-tests-ssl-option branch June 3, 2026 02:27
@hossman
Copy link
Copy Markdown
Member

hossman commented Jun 4, 2026

FWIW: This kind of feels like a half finished option?

if -Ptests.ssl=true is now a way to force tests (that support SSL) to use SSL, regardless of the randomization, then shouldn't -Ptests.ssl=false be a way to force tests to NOT use SSL, regardless of the randomization?

@dsmiley
Copy link
Copy Markdown
Contributor Author

dsmiley commented Jun 4, 2026

fair point that I stated 2 weeks ago; I was conflicted to bother with doing it (as I didn't have a need/desire) but I'll proceed with that.

@dsmiley
Copy link
Copy Markdown
Contributor Author

dsmiley commented Jun 5, 2026

@hossman see #4500

dsmiley added a commit that referenced this pull request Jun 6, 2026
Forces SSL if not suppressed.  But doesn't do the inverse yet.

(cherry picked from commit ab4564b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants