-
Notifications
You must be signed in to change notification settings - Fork 770
SOLR-17908 Add (back) cURL to docker image #3803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds the curl package back to the Solr Docker image after it was inadvertently removed during the upgrade to JRE 25 for the 10.x release.
Key Changes:
- Adds
curlto the list of installed packages in the Dockerfile template
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Heart curl! I like we have wget as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we also have wget? Can't we just pick one (curl)?
I debated the same thing. I think some folks like curl and some like wget. |
If wget is in base image we could uninstall but it would not save image size. I think curl is worth it for its familiarity in local debugging. In a distant future perhaps we get to minimal base image and jlink.. |
|
I'm not arguing for uninstallation but for removing where we ask for it, assuming we don't actually need it. |
After upgrading to a new default docker image with JRE 25 for the upcoming 10.x release (#3782), @epugh discovered that it does no longer have cURL installed by default. That's a bummer, since everyone ❤️ cURL.
This may be the smallest PR I've written in a long time :)