Skip to content

Conversation

@janhoy
Copy link
Contributor

@janhoy janhoy commented Oct 22, 2025

After upgrading to a new default docker image with JRE 25 for the upcoming 10.x release (#3782), @epugh discovered that it does no longer have cURL installed by default. That's a bummer, since everyone ❤️ cURL.

This may be the smallest PR I've written in a long time :)

@janhoy janhoy requested a review from Copilot October 22, 2025 20:48
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds the curl package back to the Solr Docker image after it was inadvertently removed during the upgrade to JRE 25 for the 10.x release.

Key Changes:

  • Adds curl to the list of installed packages in the Dockerfile template

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@github-actions github-actions bot added the docker Docker image label Oct 22, 2025
@janhoy janhoy requested review from HoustonPutman and epugh October 22, 2025 20:48
Copy link
Contributor

@epugh epugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heart curl! I like we have wget as well.

Copy link
Contributor

@dsmiley dsmiley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we also have wget? Can't we just pick one (curl)?

@epugh
Copy link
Contributor

epugh commented Oct 23, 2025

Why do we also have wget? Can't we just pick one (curl)?

I debated the same thing. I think some folks like curl and some like wget.

@janhoy
Copy link
Contributor Author

janhoy commented Oct 23, 2025

Why do we also have wget? Can't we just pick one (curl)?

If wget is in base image we could uninstall but it would not save image size. I think curl is worth it for its familiarity in local debugging.

In a distant future perhaps we get to minimal base image and jlink..

@dsmiley
Copy link
Contributor

dsmiley commented Oct 23, 2025

I'm not arguing for uninstallation but for removing where we ask for it, assuming we don't actually need it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants