SOLR-17959: Add alwaysStopwords option to edismax #3802
Merged
+35
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SOLR-17959
Description
We were surprised by
edismax's behaviour for pure-stopword queries, having expected that these would return zero results. Its 'If a query consists of all stopwords, such as "to be or not to be", then all words are required.' behaviour is the opposite to what we want as we're using query-time stopwords to prevent particular query terms matching, but there's no way to disable the behaviour other than usingdismaxinstead, which has other impacts.Solution
This PR adds an
alwaysStopwordsoption that disables the default behaviour, enabling stopwords to be always ignored.Tests
I've added tests for the default and new behaviours.
Checklist
Please review the following and check all that apply:
mainbranch../gradlew check.