SOLR-17927: Fix naming in vector search support #3789
+179
−170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
alessandrobenedetti
requested changes
Oct 22, 2025
solr/core/src/java/org/apache/solr/schema/DenseVectorField.java
Outdated
Show resolved
Hide resolved
solr/core/src/java/org/apache/solr/schema/DenseVectorField.java
Outdated
Show resolved
Hide resolved
alessandrobenedetti
approved these changes
Oct 22, 2025
cpoerschke
reviewed
Oct 23, 2025
| Attention: | ||
|
|
||
| * The `llm` module has been renamed to `language-models`. | ||
| * The HNSW parameters `hnswMaxConnections` and `hnswBeamWidth` have been renamed to `hnswM` and `hnswEfConstruction`, respectively, so they must be updated accordingly in the schema.xml file. |
There was a problem hiding this comment.
Curiosity only, I wonder if unused attributes are permitted in the schema e.g. might one go
- from
hnswMaxConnections="10" hnswBeamWidth="40"on Solr9 - to
hnswMaxConnections="10" hnswBeamWidth="40" hnswM="10" hnswEfConstruction="40"on Solr9 - to
hnswMaxConnections="10" hnswBeamWidth="40" hnswM="10" hnswEfConstruction="40"on Solr10 - to
hnswM="10" hnswEfConstruction="40"on Solr10
conceptually?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SOLR-17927
Description
I avoided adding comments with references to Lucene, since we plan to change the names there as well.