[bugfix] AMQP consumers are not living up to expectations #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
3 tasks
|
|
Hi, @renyansongno1. Thanks for the PR, should we update the plugin test scenario to verify the issue have been fixed or not? Because in the issue mentioned, sounds like we miss some scenario verify? |
ok, I will do it soon. |
|
@mrproliu I had modify scenario tests, in this tests, only need send more than 1 msg, if we can find these span, the code is work. |
mrproliu
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Interception Point Modification
Since the Consumer function of AMQP091 returns a read-only chan structure, the previous agent logic reads this chan, causing the normal business logic to miss messages.
Therefore, after my consideration, interception can be performed before the message enters this chan to process the message for tracing.
Other Modification Points
Due to the definition of the AMQP protocol itself, after the client and broker establish a connection, communication is conducted using channels. Throughout the entire communication process, the message does not contain queue name information. Hence, it is necessary to obtain the relationship between ConsumerTag and queue when the Consumer function is called. In subsequent message bodies, the Queue can be mapped out through ConsumerTag.