Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support ignore suffix #163

Merged
merged 2 commits into from
Jan 24, 2024
Merged

Add support ignore suffix #163

merged 2 commits into from
Jan 24, 2024

Conversation

CodePrometheus
Copy link
Contributor

summary

add support ignore suffix

what

Provide users with the ability to ignore the span for the operationName dimension.

why

In the actual usage environment, there are a batch of requests such as /xx.jpg. We can reduce the signal-to-noise ratio of the collection to better analyze the trace.

how

I added agent.ignore_suffix in the default configuration file, which will add a layer of judgment when creating Entry, Local and Exit spans.

additional

There is no test code added for the time being. Since I am considering the operationName dimension, I would like to discuss the topic 11807 with community members~

@wu-sheng wu-sheng requested a review from mrproliu January 23, 2024 23:50
@wu-sheng wu-sheng added this to the 0.4.0 milestone Jan 23, 2024
@wu-sheng wu-sheng added the enhancement New feature or request label Jan 23, 2024
Copy link
Contributor

@mrproliu mrproliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wu-sheng wu-sheng merged commit ffaa359 into apache:main Jan 24, 2024
34 checks passed
@CodePrometheus CodePrometheus deleted the feat_ignore_suffix branch January 24, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants