Fix on conflict error and add support for other on conflict queries in Postgres
#34227
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,128 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one or more | ||
| * contributor license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright ownership. | ||
| * The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| * (the "License"); you may not use this file except in compliance with | ||
| * the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.apache.shardingsphere.infra.binder.context.segment.insert.values; | ||
|
|
||
| import com.google.common.base.Preconditions; | ||
| import lombok.Getter; | ||
| import org.apache.shardingsphere.sql.parser.statement.core.extractor.ColumnExtractor; | ||
| import org.apache.shardingsphere.sql.parser.statement.core.extractor.ExpressionExtractor; | ||
| import org.apache.shardingsphere.sql.parser.statement.core.segment.dml.assignment.ColumnAssignmentSegment; | ||
| import org.apache.shardingsphere.sql.parser.statement.core.segment.dml.column.ColumnSegment; | ||
| import org.apache.shardingsphere.sql.parser.statement.core.segment.dml.expr.ExpressionSegment; | ||
| import org.apache.shardingsphere.sql.parser.statement.core.segment.dml.expr.FunctionSegment; | ||
| import org.apache.shardingsphere.sql.parser.statement.core.segment.dml.expr.simple.LiteralExpressionSegment; | ||
| import org.apache.shardingsphere.sql.parser.statement.core.segment.dml.expr.simple.ParameterMarkerExpressionSegment; | ||
| import org.apache.shardingsphere.sql.parser.statement.core.segment.dml.predicate.WhereSegment; | ||
|
|
||
| import java.util.ArrayList; | ||
| import java.util.Collection; | ||
| import java.util.Collections; | ||
| import java.util.LinkedList; | ||
| import java.util.List; | ||
| import java.util.Optional; | ||
| import java.util.stream.Collectors; | ||
|
|
||
| /** | ||
| * On conflict context. | ||
| */ | ||
| @Getter | ||
| public final class OnConflictUpdateContext { | ||
|
|
||
| private final int parameterCount; | ||
|
|
||
| private final List<ExpressionSegment> valueExpressions; | ||
|
|
||
| private final Collection<WhereSegment> whereSegments = new LinkedList<>(); | ||
|
|
||
| private final Collection<ColumnSegment> columnSegments; | ||
|
|
||
| private final List<ParameterMarkerExpressionSegment> parameterMarkerExpressions; | ||
|
|
||
| private final List<Object> parameters; | ||
|
|
||
| public OnConflictUpdateContext(final Collection<ColumnAssignmentSegment> assignments, final List<Object> params, final int parametersOffset, final Optional<WhereSegment> segment) { | ||
| List<ExpressionSegment> expressionSegments = assignments.stream().map(ColumnAssignmentSegment::getValue).collect(Collectors.toList()); | ||
| segment.ifPresent(whereSegments::add); | ||
| for (WhereSegment whereSegment : whereSegments) { | ||
|
There was a problem hiding this comment. Please rename whereSegment to each |
||
| expressionSegments.add(whereSegment.getExpr()); | ||
| } | ||
| columnSegments = assignments.stream().map(each -> each.getColumns().get(0)).collect(Collectors.toList()); | ||
|
There was a problem hiding this comment. Why only call There was a problem hiding this comment. Postgres ON CONFLICT clause only updates the specified conflicting column, and each assignment logically corresponds to a single column in this context. |
||
| ColumnExtractor.extractColumnSegments(columnSegments, whereSegments); | ||
| valueExpressions = getValueExpressions(expressionSegments); | ||
| parameterMarkerExpressions = ExpressionExtractor.getParameterMarkerExpressions(expressionSegments); | ||
| parameterCount = parameterMarkerExpressions.size(); | ||
| parameters = getParameters(params, parametersOffset); | ||
| } | ||
|
|
||
| /** | ||
|
There was a problem hiding this comment. Please remove javadoc for private method. |
||
| * get value expressions from expression segments. | ||
| * | ||
| * @param assignments Collection of expression segments | ||
| * @return List of value expressions | ||
| */ | ||
| private List<ExpressionSegment> getValueExpressions(final Collection<ExpressionSegment> assignments) { | ||
| List<ExpressionSegment> result = new ArrayList<>(assignments.size()); | ||
|
There was a problem hiding this comment. Only for cast Collection to List? If so, please modify the origianl assignments to ArrayList. |
||
| result.addAll(assignments); | ||
| return result; | ||
| } | ||
|
|
||
| /** | ||
|
There was a problem hiding this comment. Please remove javadoc for private method. |
||
| * get list of parameters. | ||
| * | ||
| * @param params List of parameters | ||
| * @param paramsOffset Offset in the parameter list | ||
| * @return List of parameters | ||
| */ | ||
| private List<Object> getParameters(final List<Object> params, final int paramsOffset) { | ||
| if (params.isEmpty() || 0 == parameterCount) { | ||
| return Collections.emptyList(); | ||
| } | ||
| List<Object> result = new ArrayList<>(parameterCount); | ||
| result.addAll(params.subList(paramsOffset, paramsOffset + parameterCount)); | ||
| return result; | ||
| } | ||
|
|
||
| /** | ||
| * Get value. | ||
| * | ||
| * @param index index | ||
| * @return value | ||
| */ | ||
| public Object getValue(final int index) { | ||
| ExpressionSegment valueExpression = valueExpressions.get(index); | ||
| if (valueExpression instanceof ParameterMarkerExpressionSegment) { | ||
| return parameters.get(getParameterIndex((ParameterMarkerExpressionSegment) valueExpression)); | ||
| } | ||
| if (valueExpression instanceof FunctionSegment) { | ||
| return valueExpression; | ||
| } | ||
| return ((LiteralExpressionSegment) valueExpression).getLiterals(); | ||
| } | ||
|
|
||
| /** | ||
|
There was a problem hiding this comment. Please remove javadoc for private method. |
||
| * get index of a parameter. | ||
| * | ||
| * @param paramMarkerExpression Parameter marker expression. | ||
| * @return Index of the parameter in the parameter list. | ||
| */ | ||
| private int getParameterIndex(final ParameterMarkerExpressionSegment paramMarkerExpression) { | ||
| int result = parameterMarkerExpressions.indexOf(paramMarkerExpression); | ||
| Preconditions.checkArgument(result >= 0, "Can not get parameter index."); | ||
| return result; | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add javadoc for this class.