[Improve][E2E] Improve redis test for delete hash #9946
+206
−95
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dybyte
reviewed
Oct 15, 2025
...edis-e2e/src/test/java/org/apache/seatunnel/e2e/connector/redis/RedisTestCaseTemplateIT.java
Show resolved
Hide resolved
|
How much can this modification time be reduced? |
This modification reduced the test time by almost 50%. @zhangshenghang |
dybyte
reviewed
Oct 15, 2025
...edis-e2e/src/test/java/org/apache/seatunnel/e2e/connector/redis/RedisTestCaseTemplateIT.java
Outdated
Show resolved
Hide resolved
Do you have actual screenshots? |
If we apply these changes, we can reduce the time even more. 
|
Hisoka-X
requested changes
Oct 19, 2025
...edis-e2e/src/test/java/org/apache/seatunnel/e2e/connector/redis/RedisTestCaseTemplateIT.java
Show resolved
Hide resolved
davidzollo
reviewed
Oct 26, 2025
...edis-e2e/src/test/java/org/apache/seatunnel/e2e/connector/redis/RedisTestCaseTemplateIT.java
Outdated
Show resolved
Hide resolved
zhangshenghang
approved these changes
Nov 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are currently too many use cases for redis' e2e, which will slow down the overall e2e time. Most of the use cases can be implemented through unit tests and I will optimize these e2e, which is the first merge request.