[RIP-74] Rocketmq-flink dynamic load balancing #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
December 23, 2024 23:52
ferrirW
approved these changes
Jan 10, 2025
| import java.util.concurrent.atomic.AtomicBoolean; | ||
|
|
||
| public class SpinLock { | ||
| private AtomicBoolean lock = new AtomicBoolean(true); |
| @@ -26,6 +25,8 @@ | |||
| import org.apache.flink.connector.rocketmq.source.util.UtilAll; | |||
| import org.apache.flink.util.FlinkRuntimeException; | |||
| import org.apache.flink.util.StringUtils; | |||
|
|
|||
| import com.alibaba.fastjson.JSON; | |||
There was a problem hiding this comment.
Configure IDE, avoid unnecessary changes
There was a problem hiding this comment.
Flink use specific code style, could use "mvn clean install"
lizhimins
reviewed
Jan 11, 2025
| // The internal states of the enumerator. | ||
| // This set is only accessed by the partition discovery callable in the callAsync() method. | ||
| // The current assignment by reader id. Only accessed by the coordinator thread. | ||
| // The discovered and initialized partition splits that are waiting for owner reader to be | ||
| // ready. | ||
| private final Set<MessageQueue> allocatedSet; | ||
| private final Map<MessageQueue, Byte> allocatedSet; |
There was a problem hiding this comment.
This object may be manipulated by multiple threads
| import java.util.concurrent.atomic.AtomicBoolean; | ||
|
|
||
| public class SpinLock { | ||
| private AtomicBoolean lock = new AtomicBoolean(true); |
lizhimins
reviewed
Jan 11, 2025
| // check | ||
| SourceCheckEvent sourceCheckEvent = new SourceCheckEvent(); | ||
| sourceCheckEvent.setAssignedMq(currentOffsetTable.keySet()); | ||
| sourceReaderContext.sendSourceEventToCoordinator(sourceCheckEvent); |
There was a problem hiding this comment.
send event to coordinator too frequency
There was a problem hiding this comment.
done~,It has been changed to a scheduled task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#125
docs: https://shimo.im/docs/RKAWMOEYgXfM88q8