Skip to content

fix: batch sink didn't report metrics #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: batch sink didn't report metrics #121

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/main/java/org/apache/flink/connector/rocketmq/legacy/RocketMQSink.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@ public class RocketMQSink extends RichSinkFunction<Message> implements Checkpoin
private boolean batchFlushOnCheckpoint; // false by default
private int batchSize = 32;
private List<Message> batchList;
private long batchMessageSize;

private Meter sinkInTps;
private Meter outTps;
Expand Down Expand Up @@ -112,6 +113,7 @@ public void invoke(Message input, Context context) throws Exception {

if (batchFlushOnCheckpoint) {
batchList.add(input);
batchMessageSize += input.getBody().length;
if (batchList.size() >= batchSize) {
flushSync();
}
Expand Down Expand Up @@ -220,8 +222,13 @@ private void flushSync() throws Exception {
if (batchFlushOnCheckpoint) {
synchronized (batchList) {
if (batchList.size() > 0) {
long startSinkTime = System.currentTimeMillis();
producer.send(batchList);
latencyGauge.report(System.currentTimeMillis() - startSinkTime, 1);
outTps.markEvent();
outBps.markEvent(batchMessageSize);
batchList.clear();
batchMessageSize = 0;
}
}
}
Expand Down