Skip to content

RATIS-1350. One of raftgroup initraftlog fail due to raftlog IllegalStateException #453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

RATIS-1350. One of raftgroup initraftlog fail due to raftlog IllegalStateException #453

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
90e9ff2
Support skip no permission storagedir with multiple volumes
cchenax Jan 19, 2021
3c5f8ba
Support skip the storagedir with multiple volumes which cause by bad …
cchenax Jan 20, 2021
1fbc65f
Support skip the storagedir with multiple volumes which cause by bad …
cchenax Jan 20, 2021
8c44b6b
Support skip the storagedir with multiple volumes which cause by bad …
cchenax Jan 20, 2021
0863db3
one of raftgroup initraftlog fail due to raftlog IllegalStateException
cchenax Mar 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion ratis-server/src/main/java/org/apache/ratis/server/impl/RaftServerProxy.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -349,7 +349,17 @@ private RaftServerImpl getImpl(RaftGroupId groupId) throws IOException {
List<RaftServerImpl> getImpls() throws IOException {
final List<RaftServerImpl> list = new ArrayList<>();
for(CompletableFuture<RaftServerImpl> f : impls.getAll()) {
list.add(IOUtils.getFromFuture(f, this::getId));
try {
RaftServerImpl result = f.exceptionally(e->{
LOG.warn("raft groupid " + this.getId() +" initlog is error");
return null;
}).get();
if (result != null) {
list.add(IOUtils.getFromFuture(f, this::getId));
}
} catch (InterruptedException | ExecutionException e) {
e.printStackTrace();
}
}
return list;
}
Expand Down
18 changes: 13 additions & 5 deletions ratis-server/src/main/java/org/apache/ratis/server/impl/ServerState.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@
import java.io.Closeable;
import java.io.File;
import java.io.IOException;
import java.nio.file.AccessDeniedException;
import java.util.ArrayList;
import java.util.Arrays;
import java.util.HashMap;
Expand Down Expand Up @@ -67,7 +68,7 @@ class ServerState implements Closeable {
/** The thread that applies committed log entries to the state machine */
private final StateMachineUpdater stateMachineUpdater;
/** local storage for log and snapshot */
private final RaftStorageImpl storage;
private RaftStorageImpl storage;
private final SnapshotManager snapshotManager;
private volatile Timestamp lastNoLeaderTime;
private final TimeDuration noLeaderTimeout;
Expand Down Expand Up @@ -103,10 +104,17 @@ class ServerState implements Closeable {
configurationManager = new ConfigurationManager(initialConf);
LOG.info("{}: {}", getMemberId(), configurationManager);

// use full uuid string to create a subdirectory
final File dir = chooseStorageDir(RaftServerConfigKeys.storageDir(prop),
group.getGroupId().getUuid().toString());
storage = new RaftStorageImpl(dir, RaftServerConfigKeys.Log.corruptionPolicy(prop));
List<File> directories = RaftServerConfigKeys.storageDir(prop);
while (!directories.isEmpty()) {
// use full uuid string to create a subdirectory
File dir = chooseStorageDir(directories, group.getGroupId().getUuid().toString());
try {
storage = new RaftStorageImpl(dir, RaftServerConfigKeys.Log.corruptionPolicy(prop));
break;
} catch (AccessDeniedException e) {
directories.remove(dir);
}
}
snapshotManager = new SnapshotManager(storage, id);

stateMachine.initialize(server.getRaftServer(), group.getGroupId(), storage);
Expand Down