RATIS-2629. Handle Netty based request asynchronously and improve exception handling - #1538
Open
spacemonkd wants to merge 1 commit into
Open
RATIS-2629. Handle Netty based request asynchronously and improve exception handling#1538spacemonkd wants to merge 1 commit into
spacemonkd wants to merge 1 commit into
Conversation
Contributor
Author
|
@szetszwo could you take a look? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
RATIS-2629. Handle Netty based request asynchronously and improve exception handling
Currently NettyRpcService handles every inbound request synchronously on the Netty IO event-loop thread and its inbound handler does not override exceptionCaught.
This can cause:
This patch offloads the request handling out of the core IO path, and closes the channel to prevent blocking.
This mirrors how gRPC handles the requests.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/RATIS-2629
How was this patch tested?
Patch was tested via unit tests.