Skip to content

Conversation

@rameeshm
Copy link
Contributor

What changes were proposed in this pull request?

Filter was not working correctly with previous patch related to RANGER-5376

How was this patch tested?

Did curl call to check that filter dataSetIds= works fine.
curl -k -u : --negotiate "https://:6182/service/assets/accessAudit?pageSize=25&startIndex=0&sortBy=eventTime&sortType=desc&datasetIds=1&agentId=restCatalog&repoType=3" | python -m json.tool

…arching with DataSet Ids -Fixed filter issue
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request fixes a filter issue in the Ranger audit event search functionality related to dataset IDs. The previous implementation used the singular parameter name "datasetId" which was inconsistent with the API endpoint that expects "datasetIds" (plural).

Key Changes:

  • Updated the parameter name from "datasetId" to "datasetIds" to match the API endpoint
  • Added the corresponding search field definition for "datasetIds" in the search configuration

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
AssetREST.java Fixed parameter name from "datasetId" to "datasetIds" in the access logs endpoint
AccessAuditsService.java Added search field definition for "datasetIds" parameter

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant