-
Notifications
You must be signed in to change notification settings - Fork 993
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RANGER-4876: Plugin Analytics #369
Open
fateh288
wants to merge
2
commits into
apache:master
Choose a base branch
from
fateh288:RANGER-4876
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+75
−0
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
69 changes: 69 additions & 0 deletions
69
agents-common/src/main/java/org/apache/ranger/plugin/service/RangerPluginAnalytics.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,69 @@ | ||
/* | ||
* Licensed to the Apache Software Foundation (ASF) under one | ||
* or more contributor license agreements. See the NOTICE file | ||
* distributed with this work for additional information | ||
* regarding copyright ownership. The ASF licenses this file | ||
* to you under the Apache License, Version 2.0 (the | ||
* "License"); you may not use this file except in compliance | ||
* with the License. You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, | ||
* software distributed under the License is distributed on an | ||
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
* KIND, either express or implied. See the License for the | ||
* specific language governing permissions and limitations | ||
* under the License. | ||
*/ | ||
package org.apache.ranger.plugin.service; | ||
|
||
import java.util.concurrent.Executors; | ||
import java.util.concurrent.ScheduledExecutorService; | ||
import java.util.concurrent.ScheduledFuture; | ||
|
||
import org.slf4j.Logger; | ||
import org.slf4j.LoggerFactory; | ||
import java.util.concurrent.atomic.DoubleAccumulator; | ||
|
||
import static java.util.concurrent.TimeUnit.SECONDS; | ||
|
||
public class RangerPluginAnalytics { | ||
private static final Logger LOG = LoggerFactory.getLogger(RangerPluginAnalytics.class); | ||
private final ScheduledExecutorService scheduler = Executors.newScheduledThreadPool(1); | ||
private static final int SLEEP_DURATION = 300; | ||
private ScheduledFuture<?> statusHandler; | ||
|
||
private final DoubleAccumulator countIsAccessAllowed = new DoubleAccumulator(Double::sum, 0L); | ||
final Runnable asyncLoggerPluginAnalytics = () -> { | ||
LOG.info("===========Ranger Plugin Analytics============="); | ||
LOG.info("Accumulation period in seconds:"+SLEEP_DURATION); | ||
LOG.info("Number of times isAccessAllowed was called:"+countIsAccessAllowed.getThenReset()); | ||
}; | ||
|
||
public void startPluginAnalytics() { | ||
stopPluginAnalytics(); | ||
LOG.info("Starting Scheduled Plugin Analytics"); | ||
statusHandler = scheduler.scheduleWithFixedDelay(asyncLoggerPluginAnalytics, 0, SLEEP_DURATION, SECONDS); | ||
} | ||
|
||
public void stopPluginAnalytics() { | ||
if (statusHandler == null){ | ||
LOG.info("statusHandler is null, stop not required for asyncLoggerPluginAnalytics"); | ||
return; | ||
} | ||
LOG.info("Attempting to cancel asyncLoggerPluginAnalytics"); | ||
scheduler.shutdown(); | ||
statusHandler.cancel(true); | ||
if (statusHandler.isDone()){ | ||
LOG.info("Canceled asyncLoggerPluginAnalytics"); | ||
} | ||
else{ | ||
LOG.info("Could not cancel asyncLoggerPluginAnalytics"); | ||
} | ||
} | ||
|
||
public void addIsAccessAllowedCount(){ | ||
countIsAccessAllowed.accumulate(1); | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RangerBasePlugin has 6 constructor, "pluginAnalytics " instance variable is not getting initialised from all 6 code paths. Please do let me know if i am looking the wrong code base.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see just 4 constructors - line 511, 515, 519 and 565 - in RangerBasePlugin.java
@vyommani Can you point to the other 2 constructors you are seeing ?
Constructor 1: Always calls constructor 3
Constructor 2: Always calls constructor 4
So I added pluginAnalytics function calls only for constructor 3 and constructor 4.
Adding it to all the 4 constructors would result in double counting