[improve] Upgrade RoaringBitmap to 1.6.6 version#25253
Draft
lhotari wants to merge 1 commit intoapache:masterfrom
Draft
[improve] Upgrade RoaringBitmap to 1.6.6 version#25253lhotari wants to merge 1 commit intoapache:masterfrom
lhotari wants to merge 1 commit intoapache:masterfrom
Conversation
Member
Author
|
Let's wait for RoaringBitmap/RoaringBitmap#824 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #25253 +/- ##
============================================
- Coverage 72.75% 72.59% -0.16%
+ Complexity 34068 33888 -180
============================================
Files 1959 1959
Lines 155401 155401
Branches 17724 17724
============================================
- Hits 113062 112818 -244
- Misses 33364 33590 +226
- Partials 8975 8993 +18
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
There have been improvements and bug fixes in RoaringBitmap since 1.2.0 version. We haven't been able to upgrade since the artifact hasn't been published to maven central for a while. RoaringBitmap is now available in maven central with coordinates
org.roaringbitmap:roaringbitmapthis has changed from the previousorg.roaringbitmap:RoaringBitmapdependency. Pulsar users using pulsar-client-original without shading might need to pay attention to this detail if they are depending onorg.roaringbitmap:RoaringBitmapdirectly since that would cause 2 versions of the library on the classpath simultaneously. Either one would be used.Modifications
Documentation
docdoc-requireddoc-not-neededdoc-complete