[fix][client] Fix retry logic for BinaryProtoLookupService.getTopicsUnderNamespace method #24974
+228
−128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhotari
added
type/bug
…Cnx to ease unit testing
lhotari
force-pushed
the
lh-fix-gettopics-retries
branch
from
2da65d4 to
2562c19
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #24974 +/- ##
=============================================
+ Coverage 38.69% 74.28% +35.58%
- Complexity 13362 34017 +20655
=============================================
Files 1863 1920 +57
Lines 145975 150236 +4261
Branches 16928 17428 +500
=============================================
+ Hits 56487 111604 +55117
+ Misses 81858 29719 -52139
- Partials 7630 8913 +1283
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Denovo1998
reviewed
Nov 17, 2025
| private final Queue<Object> queue = Queues.newArrayDeque(); | ||
|
|
||
| public ClientChannelHelper() { | ||
| int maxMessageSize = 5 * 1024 * 1024; |
Denovo1998
reviewed
Nov 17, 2025
| }, lookupPinnedExecutor).whenComplete((r, t) -> { | ||
| if (t != null) { | ||
| Throwable cause = FutureUtil.unwrapCompletionException(t); | ||
| if (cause instanceof PulsarClientException && !PulsarClientException.isRetriableError(cause)) { |
Contributor
There was a problem hiding this comment.
Is it covered in the test here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
BinaryProtoLookupService.getTopicsUnderNamespace method contains retry logic, but it only applies to exceptions that occur when acquiring the connection fails.
A getTopicsUnderNamespace might fail later if the connection gets closed before the response has been successfully received. That's why it's better that the retry logic would also cover the actual operation to be effective.
Modifications
Documentation
docdoc-requireddoc-not-neededdoc-complete