[fix][test]fix flaky SimpleProducerConsumerTest.testReceiveAsyncCompletedWhenClosing #24858
+19
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #24850
Motivation
The test
testReceiveAsyncCompletedWhenClosingwas experiencing concurrency race conditions that caused flaky test failures. The issue occurred due to unpredictable timing between two operations:consumer.receiveAsync()orbatchReceiveAsync()consumer.close()Expected behavior:
Flaky scenario:
close()executes before receiveAsync(), the subsequentreceiveAsync()call immediately returns aCompletableFuturethat completes with aPulsarClientExceptioncontaining the message "Consumer already closed". This differs from the expected interruption behavior and causes the test assertion to fail.Modifications
ensure
consumer.receiveAsync()happens beforeconsumer.close()Solution
Added proper synchronization using CountDownLatch to ensure:
The async operation (receiveAsync/batchReceiveAsync) starts first
The close() operation executes only after the async operation has begun
Verifying this change
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: 3pacccccc#27