Fix incorrect python spec name for release wheels workflow#177
Merged
RobertIndie merged 1 commit intoapache:mainfrom Dec 19, 2023
Merged
Fix incorrect python spec name for release wheels workflow#177RobertIndie merged 1 commit intoapache:mainfrom
RobertIndie merged 1 commit intoapache:mainfrom
Conversation
BewareMyPower
approved these changes
Dec 19, 2023
shibd
approved these changes
Dec 19, 2023
RobertIndie
added a commit
that referenced
this pull request
Dec 20, 2023
There is an error when building the wheel for python12:
```
Dockerfile:35
--------------------
33 | ENV PYTHON_LIBRARIES /opt/python/${PYTHON_SPEC}/lib/python${PYTHON_VERSION}
34 |
35 | >>> RUN pip3 install pyyaml
36 |
37 | ADD .build/dependencies.yaml /
--------------------
```
More context: https://github.com/apache/pulsar-client-python/actions/runs/7246274042/job/19737879474#step:6:237
The python spec name is incorrect in the github release wheels workflow. These are all specs in the manylinux2014:
```
[root@82c96c919b6f /]# cd /opt/python/
[root@82c96c919b6f python]# ll
total 0
lrwxrwxrwx 1 root root 30 Dec 18 19:58 cp310-cp310 -> /opt/_internal/cpython-3.10.13
lrwxrwxrwx 1 root root 29 Dec 18 19:57 cp311-cp311 -> /opt/_internal/cpython-3.11.7
lrwxrwxrwx 1 root root 29 Dec 18 19:57 cp312-cp312 -> /opt/_internal/cpython-3.12.1
lrwxrwxrwx 1 root root 29 Dec 18 19:57 cp36-cp36m -> /opt/_internal/cpython-3.6.15
lrwxrwxrwx 1 root root 29 Dec 18 19:57 cp37-cp37m -> /opt/_internal/cpython-3.7.17
lrwxrwxrwx 1 root root 29 Dec 18 19:57 cp38-cp38 -> /opt/_internal/cpython-3.8.18
lrwxrwxrwx 1 root root 29 Dec 18 19:57 cp39-cp39 -> /opt/_internal/cpython-3.9.18
lrwxrwxrwx 1 root root 33 Dec 18 19:58 pp310-pypy310_pp73 -> /opt/_internal/pp310-pypy310_pp73
lrwxrwxrwx 1 root root 31 Dec 18 19:58 pp37-pypy37_pp73 -> /opt/_internal/pp37-pypy37_pp73
lrwxrwxrwx 1 root root 31 Dec 18 19:58 pp38-pypy38_pp73 -> /opt/_internal/pp38-pypy38_pp73
lrwxrwxrwx 1 root root 31 Dec 18 19:58 pp39-pypy39_pp73 -> /opt/_internal/pp39-pypy39_pp73
```
This PR fixes the incorrect spec name for python12.
(cherry picked from commit bf8524a)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is an error when building the wheel for python12:
More context: https://github.com/apache/pulsar-client-python/actions/runs/7246274042/job/19737879474#step:6:237
The python spec name is incorrect in the github release wheels workflow. These are all specs in the manylinux2014:
This PR fixes the incorrect spec name for python12.