opt: delete redundant channel connection.incomingCmdCh

[gunli]

Fixes #

Master Issue: #1335 #1336

Motivation

Reading is run in a seperate goroutine, connection.incomingCmdCh is redundant, just call connection.internalReceivedCommand() directly.

func (c *connection) run() {
	pingSendTicker := time.NewTicker(c.keepAliveInterval)
	pingCheckTicker := time.NewTicker(c.keepAliveInterval)

	defer func() {
		// stop tickers
		pingSendTicker.Stop()
		pingCheckTicker.Stop()

		// all the accesses to the pendingReqs should be happened in this run loop thread,
		// including the final cleanup, to avoid the issue
		// https://github.com/apache/pulsar-client-go/issues/239
		c.failPendingRequests(errConnectionClosed)
		c.Close()
	}()

	// All reads come from the reader goroutine
	go c.reader.readFromConnection()  // reading is run in a SEPERATE goroutine here
	go c.runPingCheck(pingCheckTicker)
}

Modifications

delete redundant channel connection.incomingCmdCh

Verifying this change

• Make sure that the change passes the CI checks.

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

• Dependencies (does it add or upgrade a dependency): (no)
• The public API: (yes / no)
• The schema: (yes / no / don't know)
• The default values of configurations: (yes / no)
• The wire protocol: (yes / no)

Documentation

• Does this pull request introduce a new feature? (no)
• If yes, how is the feature documented? (not applicable / docs / GoDocs / not documented)
• If a feature is not applicable for documentation, explain why?
• If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

[gunli]

@shibd @nodece @RobertIndie @BewareMyPower @crossoverJie

[nodece]

LGTM

[nodece]

In the Golang, we must use the separate goroutine to perform the read and write operation.

[crossoverJie]

LGTM