Add support for managing offload policies in namespaces and topics#1324
Open
dn0 wants to merge 1 commit intoapache:masterfrom
Open
Add support for managing offload policies in namespaces and topics#1324dn0 wants to merge 1 commit intoapache:masterfrom
dn0 wants to merge 1 commit intoapache:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This change adds public methods for managing offload policies at the namespace and topic level.
The main motivation is to later use these functions in the Terraform provider which we are planning to extend as well to be able to manage offloading policies via Terraform.
Modifications
I was trying to figure out the naming to be consistent with the REST API and other methods.
Feel free to suggest different naming structure.
Added the following methods:
Verifying this change
This change added tests and can be verified as follows:
Does this pull request potentially affect one of the following parts:
noyesdon't knowyesnoDocumentation
yesGoDocs?