include additional context in the error message.#1317
Open
walkinggo wants to merge 1 commit intoapache:masterfrom
Open
include additional context in the error message.#1317walkinggo wants to merge 1 commit intoapache:masterfrom
walkinggo wants to merge 1 commit intoapache:masterfrom
Conversation
RobertIndie
reviewed
Dec 16, 2024
Member
RobertIndie
left a comment
There was a problem hiding this comment.
What additional context do you want? It seems you've added unnecessary details to the log, such as "WARN[0009]" and "[::1]:6650".
Author
|
Yes, I also think this is the problem. My error message depends on the example provided in the original issue. Actually, I’m not sure what kind of contextual information is needed. Could you give me some advice? @RobertIndie |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(If this PR fixes a github issue, please add
Fixes #<xyz>.)Fixes #<1315>
(or if this PR is one task of a github issue, please add
Master Issue: #<xyz>to link to the master issue.)Master Issue:
Motivation
New error to provide more detailed information, you can include additional context in the error message.
Modifications
modify the errors in connection waitUntilReady().
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation