Fix incorrect ledgerID and entryID logged when producer receives unexpected ack#1162
Open
RobertIndie wants to merge 5 commits intoapache:masterfrom
Open
Fix incorrect ledgerID and entryID logged when producer receives unexpected ack#1162RobertIndie wants to merge 5 commits intoapache:masterfrom
RobertIndie wants to merge 5 commits intoapache:masterfrom
Conversation
Contributor
|
I think this ci failed is because the PR added Golang example: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1160
Motivation
The producer should log the ledgerId and entryId with -1 when receives unexpected ack
Modifications
Verifying this change
The log now looks like:
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation