Fix arg-matching in ExceptionMapperTest.testFullExceptionIsLogged() #2531
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The above test asserts the the log record passed to `org.jboss.logmanager.Logger#logRaw(org.jboss.logmanager.ExtLogRecord)`. For the sake of this test, both the `IcebergJsonProcessingExceptionMapper` and `IcebergExceptionMapper` have a visible-for-testing function `getLogger()` to provide a mocked logger. `getLogger()` however is used for "all the logging", which makes the behavior `verify(JBOSS_LOGGER).logRaw(argThat(...))` "interesting" - the test fails with apache#2461 although no related dependencies have changed in that PR. But eventually the test failure's caused by using `getLogger()` for all logging, which may provide the _wrong_ log record and cause the test to fail. This change renames the `getLogger()` functions to make their special meaning clear, and adds some clarifying comments in the code. Also adding some more test cases for the various exception mapper code paths.
adutra
previously approved these changes
Sep 10, 2025
runtime/service/src/main/java/org/apache/polaris/service/exception/IcebergExceptionMapper.java
Outdated
Show resolved
Hide resolved
github-project-automation
bot
moved this from PRs In Progress
to Ready to merge
in Basic Kanban Board
…tion/IcebergExceptionMapper.java Co-authored-by: Alexandre Dutra <[email protected]>
adutra
approved these changes
Sep 10, 2025
dimas-b
approved these changes
Sep 10, 2025
github-project-automation
bot
moved this from Ready to merge
to Done
in Basic Kanban Board
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The above test asserts the the log record passed to
org.jboss.logmanager.Logger#logRaw(org.jboss.logmanager.ExtLogRecord). For the sake of this test, both theIcebergJsonProcessingExceptionMapperandIcebergExceptionMapperhave a visible-for-testing functiongetLogger()to provide a mocked logger.getLogger()however is used for "all the logging", which makes the behaviorverify(JBOSS_LOGGER).logRaw(argThat(...))"interesting" - the test fails with #2461 although no related dependencies have changed in that PR.But eventually the test failure's caused by using
getLogger()for all logging, which may provide the wrong log record and cause the test to fail.This change renames the
getLogger()functions to make their special meaning clear, and adds some clarifying comments in the code.Also adding some more test cases for the various exception mapper code paths.